added currency support checking

index.php

@@ -1,10 +1,8 @@
 <?php
-ini_set('display_errors', 1);
-error_reporting(E_ALL);
+//ini_set('display_errors', 1);
+//error_reporting(E_ALL);
 
 require_once 'vendor/autoload.php';
-require_once 'vendor/seigler/neat-charts/src/NeatCharts/NeatChart.php';
-require_once 'vendor/seigler/neat-charts/src/NeatCharts/LineChart.php';
 
 use phpFastCache\CacheManager;
 
@@ -20,19 +18,18 @@ $router->map('GET', '/', function() {
 });
 
 // map cryptocurrency stuff
-$router->map( 'GET', '/charts/[dark|light:theme]/[a:curA]-[a:curB]/[7d|24h:duration]/[svg|png:format]', function($theme, $curA, $curB, $duration, $format) {
+$router->map( 'GET', '/charts/[dark|light:theme]/[a:curA]-[btc:curB]/[a:duration]/[svg|png:format]', function($theme, $curA, $curB, $duration, $format) {
   require __DIR__ . '/views/chart.php';
-  renderChart(
+  return renderChart(
     $theme,
-    strtoupper($curB.'_'.$curA),
-    60 * 60 * 24 * ($duration == '7d' ? 7 : 1),
-    ($duration == '7d' ? 1800 : 300),
+    $curA,
+    $curB,
+    $duration,
     $format,
     800,
     200,
     12
   );
-  return true;
 });
 
 // match current request url

views/chart.php

@@ -22,15 +22,53 @@ function getJson($url) {
 
 function renderChart(
   $theme,
-  $pair,
-  $dataDuration = (7 * 24 * 60 * 60),
-  $dataResolution = 1800,
+  $currencyA,
+  $currencyB,
+  $duration,
   $format = 'svg',
   $width = 800,
   $height = 200,
   $fontSize = 12
 ) {
 
+  $durations = [
+//    '30d'=> [
+//      'duration' => 60 * 60 * 24 * 30,
+//      'resolution' => 7200 // 2h
+//    ],
+    '7d'=> [
+      'duration' => 60 * 60 * 24 * 7,
+      'resolution' => 1800 // 30m
+    ],
+    '24h' => [
+      'duration' => 60 * 60 * 24 * 1,
+      'resolution' => 900 // 15m
+    ]
+  ];
+
+  if (array_key_exists($duration, $durations)) {
+    $dataDuration = $durations[$duration]['duration'];
+    $dataResolution = $durations[$duration]['resolution'];
+  } else {
+    return false;
+  }
+
+  $supportedCurrencies = CacheManager::get('poloniex-supported-currencies');
+  if (is_null($supportedCurrencies)) {
+    $supportedCurrenciesJson = getJson('https://poloniex.com/public?command=returnCurrencies');
+    foreach ($supportedCurrenciesJson as $key => $value) {
+      if ($value->delisted == 0) {
+        $supportedCurrencies[] = strtolower($key);
+      }
+    }
+    CacheManager::set('poloniex-supported-currencies', $supportedCurrencies, 60 * 60 * 24 * 7); // asking once a week doesn't seem like too much
+  }
+  if ($currencyB != 'btc' || !in_array($currencyA, $supportedCurrencies)) {
+    return false;
+  }
+
+  $pair = strtoupper($currencyB . '_' . $currencyA); // poloniex you strange
+
   $chartCacheKey = 'poloniex-'.$theme.'-'.$pair.'-'.$dataDuration.'-'.$format;
 
   $result = CacheManager::get($chartCacheKey);
@@ -88,4 +126,5 @@ function renderChart(
     header('Content-Disposition: inline; filename="Dash-chart-' . gmdate('Y-m-d\THis+0', $startTime) . '--' . gmdate('Y-m-d\THis+0') . '.png"');
   }
   echo $result;
+  return true;
 }

views/index.php

@@ -54,16 +54,16 @@
     <section>
       <h2>Poloniex Dash/BTC Price</h2>
       <figure>
-        <img src="/charts/dark/dash/7d/svg" alt="Poloniex Dash/BTC price">
+        <img src="/charts/dark/dash-btc/7d/svg" alt="Poloniex Dash/BTC price">
         <figcaption>7 Day Dash price in BTC <code>http://cryptohistory.org/charts/dark/dash-btc/7d/svg</code></figcaption>
       </figure>
     </section>
     <section>
       <h2>Build your own chart:</h2>
       <p>The URL is flexible:<br>
-        <code>http://cryptohistory.org/charts/{theme}/{currency}/{timespan}/{format}</code>.</p>
+        <code>http://cryptohistory.org/charts/{theme}/{currency}-btc/{timespan}/{format}</code>.</p>
       <p>Theme: <code>dark</code> or <code>light</code>. (More planned)</p>
-      <p>Currency: anything active on Poloniex.</p>
+      <p>Currency: anything active on Poloniex. Prices are all in bitcoin.</p>
       <p>Timespan: <code>30d</code>, <code>7d</code>, or <code>24h</code>. (More planned)</p>
       <p>Format: <code>svg</code> (best) or <code>png</code>.</p>
     </section>