RPC - Add combinerawtransaction (#162)

* RPC - Add combinerawtransaction

* Add links to other rawtx RPCs

_autocrossref.yaml

@@ -303,6 +303,8 @@ DIP8:
 '`clearbanned` RPC': rpc clearbanned
 '`createmultisig`': rpc createmultisig
 '`createmultisig` RPC': rpc createmultisig
+'`combinerawtransaction`': rpc combinerawtransaction
+'`combinerawtransaction` RPC': rpc combinerawtransaction
 '`createrawtransaction`': rpc createrawtransaction
 '`createrawtransaction` RPC': rpc createrawtransaction
 '`debug`': rpc debug

_config.yml

@@ -173,6 +173,7 @@ devsearches:
     - 'BLS': "/en/developer-reference#bls"
     - 'ClearBanned': "/en/developer-reference#clearbanned"
     - 'CreateMultisig': "/en/developer-reference#createmultisig"
+    - 'CombineRawTransaction': "/en/developer-reference#combinerawtransaction"
     - 'CreateRawTransaction': "/en/developer-reference#createrawtransaction"
     - 'Debug': "/en/developer-reference#debug"
     - 'DecodeRawTransaction': "/en/developer-reference#decoderawtransaction"

_includes/devdoc/dash-core/rpcs/quick-reference.md

@@ -246,6 +246,7 @@ These RPCs are all Dash-specific and not found in Bitcoin Core
 
 {% autocrossref %}
 
+* [CombineRawTransaction][rpc combinerawtransaction]: {{summary_combineRawTransaction}} {{DASH_NEW0_14_1}}
 * [CreateRawTransaction][rpc createrawtransaction]: {{summary_createRawTransaction}} {{DASH_UPDATED0_12_3}} {{UPDATED0_14_1}}
 * [DecodeRawTransaction][rpc decoderawtransaction]: {{summary_decodeRawTransaction}} {{UPDATED0_13_0}}
 * [DecodeScript][rpc decodescript]: {{summary_decodeScript}}

_includes/devdoc/dash-core/rpcs/rpcs/combinerawtransaction.md

@@ -0,0 +1,78 @@
+{% comment %}
+This file is licensed under the MIT License (MIT) available on
+http://opensource.org/licenses/MIT.
+{% endcomment %}
+{% assign filename="_includes/devdoc/dash-core/rpcs/rpcs/combinerawtransaction.md" %}
+
+<!--__-->
+
+##### CombineRawTransaction
+{% include helpers/subhead-links.md %}
+
+{% assign summary_combineRawTransaction="combine multiple partially signed transactions into one transaction." %}
+
+{% autocrossref %}
+
+The `combinerawtransaction` RPC {{summary_combineRawTransaction}}
+
+The combined transaction may be another partially signed transaction or a
+fully signed transaction.
+
+*Parameter #1---txs*
+
+{% itemplate ntpd1 %}
+- n: "txs"
+  t: "string"
+  p: "Required"
+  d: "A json array of hex strings of partially signed transactions"
+
+{% enditemplate %}
+
+*Result---hex-encoded raw transaction with signature(s)*
+
+{% itemplate ntpd1 %}
+- n: "`result`"
+  t: "string"
+  p: "Required<br>(Exactly 1)"
+  d: "The resulting raw transaction in serialized transaction format encoded as hex."
+
+{% enditemplate %}
+
+*Example from Dash Core 0.14.1*
+
+The following example shows a fully signed two input transaction being assembled
+by combining two partially signed transactions. The first hex-encoded string is
+the transaction with only the first input signed. The second hex-encoded string is
+the transaction with only the second input signed.
+
+{% highlight bash %}
+dash-cli combinerawtransaction '[
+ "0200000002fdb27b4f2b80a5fd3b96602618a6ccf7bdde504bf90989610b19ed6ecd769520010000006b483045022100f8770316327966fb1972338d14db8d38048455da8b62f6350b117c797cea459e02206c63c103cf53ce1d24a313b3e6853913fa14febafd733e683b6eb46a7beec0fa012103c67d86944315838aea7ec80d390b5d09b91b62483370d4979da5ccf7a7df77a9ffffffff0d052e9b13c53bb342d772767732ffe4fa9f1c150629d3fa79655267baa7c86a0100000000ffffffff0200ca9a3b000000001976a9144139b147b5cef5fef5bcdb02fcdf55e426f74dbb88ac00daf89a000000001976a91465f53f2095c99ce152ff3bc8a8f027d8a77cbdcb88ac00000000",
+ "0200000002fdb27b4f2b80a5fd3b96602618a6ccf7bdde504bf90989610b19ed6ecd7695200100000000ffffffff0d052e9b13c53bb342d772767732ffe4fa9f1c150629d3fa79655267baa7c86a010000006b4830450221008c3abc11ea84cc98cf674afc5b6d3d078d672768d289f2ab976ea4b2a49129fc022008470458b1b179800e7f5348196d510d2f147e69fe836c94135fc5c620312acd012102912ba98d6641f79864d04d41523167f5db267e45d1633e9243a0be7efb675719ffffffff0200ca9a3b000000001976a9144139b147b5cef5fef5bcdb02fcdf55e426f74dbb88ac00daf89a000000001976a91465f53f2095c99ce152ff3bc8a8f027d8a77cbdcb88ac00000000"
+]'
+{% endhighlight %}
+
+Result:
+{% highlight bash %}
+0200000002fdb27b4f2b80a5fd3b96602618a6ccf7bdde504bf90989610b19ed6ecd7695\
+20010000006b483045022100f8770316327966fb1972338d14db8d38048455da8b62f635\
+0b117c797cea459e02206c63c103cf53ce1d24a313b3e6853913fa14febafd733e683b6e\
+b46a7beec0fa012103c67d86944315838aea7ec80d390b5d09b91b62483370d4979da5cc\
+f7a7df77a9ffffffff0d052e9b13c53bb342d772767732ffe4fa9f1c150629d3fa796552\
+67baa7c86a010000006b4830450221008c3abc11ea84cc98cf674afc5b6d3d078d672768\
+d289f2ab976ea4b2a49129fc022008470458b1b179800e7f5348196d510d2f147e69fe83\
+6c94135fc5c620312acd012102912ba98d6641f79864d04d41523167f5db267e45d1633e\
+9243a0be7efb675719ffffffff0200ca9a3b000000001976a9144139b147b5cef5fef5bc\
+db02fcdf55e426f74dbb88ac00daf89a000000001976a91465f53f2095c99ce152ff3bc8\
+a8f027d8a77cbdcb88ac00000000
+{% endhighlight %}
+
+*See also:*
+
+* [CreateRawTransaction][rpc createrawtransaction]: {{summary_createRawTransaction}}
+* [DecodeRawTransaction][rpc decoderawtransaction]: {{summary_decodeRawTransaction}}
+* [SignRawTransaction][rpc signrawtransaction]: {{summary_signRawTransaction}}
+* [SendRawTransaction][rpc sendrawtransaction]: {{summary_sendRawTransaction}}
+* [Serialized Transaction Format][raw transaction format]
+
+{% endautocrossref %}

_includes/devdoc/dash-core/rpcs/rpcs/createrawtransaction.md

@@ -110,6 +110,7 @@ cfc9f32ef388acc0a8f9be010000001976a914811eacc14db8ebb5b64486dc43400c0226b4\
 
 *See also*
 
+* [CombineRawTransaction][rpc combinerawtransaction]: {{summary_combineRawTransaction}}
 * [DecodeRawTransaction][rpc decoderawtransaction]: {{summary_decodeRawTransaction}}
 * [SignRawTransaction][rpc signrawtransaction]: {{summary_signRawTransaction}}
 * [SendRawTransaction][rpc sendrawtransaction]: {{summary_sendRawTransaction}}

_includes/devdoc/dash-core/rpcs/rpcs/decoderawtransaction.md

@@ -176,6 +176,7 @@ Result:
 
 *See also*
 
+* [CombineRawTransaction][rpc combinerawtransaction]: {{summary_combineRawTransaction}}
 * [CreateRawTransaction][rpc createrawtransaction]: {{summary_createRawTransaction}}
 * [SignRawTransaction][rpc signrawtransaction]: {{summary_signRawTransaction}}
 * [SendRawTransaction][rpc sendrawtransaction]: {{summary_sendRawTransaction}}

_includes/devdoc/dash-core/rpcs/rpcs/sendrawtransaction.md

@@ -76,6 +76,7 @@ Result:
 
 *See also*
 
+* [CombineRawTransaction][rpc combinerawtransaction]: {{summary_combineRawTransaction}}
 * [CreateRawTransaction][rpc createrawtransaction]: {{summary_createRawTransaction}}
 * [DecodeRawTransaction][rpc decoderawtransaction]: {{summary_decodeRawTransaction}}
 * [SignRawTransaction][rpc signrawtransaction]: {{summary_signRawTransaction}}

_includes/devdoc/dash-core/rpcs/rpcs/signrawtransaction.md

@@ -132,6 +132,7 @@ Result:
 
 *See also*
 
+* [CombineRawTransaction][rpc combinerawtransaction]: {{summary_combineRawTransaction}}
 * [CreateRawTransaction][rpc createrawtransaction]: {{summary_createRawTransaction}}
 * [DecodeRawTransaction][rpc decoderawtransaction]: {{summary_decodeRawTransaction}}
 * [SendRawTransaction][rpc sendrawtransaction]: {{summary_sendRawTransaction}}

_includes/helpers/summaries.md

@@ -7,6 +7,7 @@ This file is licensed under the terms of its source texts{%endcomment%}
 {% assign summary_backupWallet="safely copies `wallet.dat`<!--noref--> to the specified file, which can be a directory or a path with filename." %}
 {% assign summary_bls="provides a set of commands to execute BLS-related actions." %}
 {% assign summary_clearBanned="clears list of banned nodes." %}
+{% assign summary_combineRawTransaction="combine multiple partially signed transactions into one transaction." %}
 {% assign summary_createMultiSig="creates a P2SH multi-signature address." %}
 {% assign summary_createRawTransaction="creates an unsigned serialized transaction that spends a previous output to a new output with a P2PKH or P2SH address. The transaction is not stored in the wallet or transmitted to the network." %}
 {% assign summary_debug="changes the debug category from the console." %}

_includes/layout/base/rpc-table.html

@@ -481,6 +481,12 @@ th.tg-sort-header::-moz-selection { background:transparent; }th.tg-sort-header::
     <td class="tg-dzk6">Y</td>
     <td class="tg-dzk6"></td>
   </tr>
+  <tr>
+    <td class="tg-yw4l">Rawtransactions</td>
+    <td class="tg-yw4l"><a href="#combinerawtransaction">CombineRawTransaction</a></td>
+    <td class="tg-baqh">Y</td>
+    <td class="tg-baqh">Added in 0.14.1</td>
+  </tr>
   <tr>
     <td class="tg-yw4l">Rawtransactions</td>
     <td class="tg-yw4l"><a href="#createrawtransaction">CreateRawTransaction</a></td>

_includes/references.md

@@ -76,6 +76,7 @@ http://opensource.org/licenses/MIT.
 [rpc bls]: /en/developer-reference#bls
 [rpc clearbanned]: /en/developer-reference#clearbanned
 [rpc createmultisig]: /en/developer-reference#createmultisig
+[rpc combinerawtransaction]: /en/developer-reference#combinerawtransaction
 [rpc createrawtransaction]: /en/developer-reference#createrawtransaction
 [rpc debug]: /en/developer-reference#debug
 [rpc decoderawtransaction]: /en/developer-reference#decoderawtransaction

en/developer-reference.md

@@ -86,6 +86,8 @@ untrusted source.
 
 {% include devdoc/dash-core/rpcs/rpcs/createmultisig.md %}
 
+{% include devdoc/dash-core/rpcs/rpcs/combinerawtransaction.md %}
+
 {% include devdoc/dash-core/rpcs/rpcs/createrawtransaction.md %}
 
 {% include devdoc/dash-core/rpcs/rpcs/debug.md %}