From 4d718ae671605ab375ee70ec850d0620e93e0a01 Mon Sep 17 00:00:00 2001 From: thephez Date: Tue, 20 Aug 2019 11:48:32 -0400 Subject: [PATCH] RPC - IS changes - Remove instantsend field from result of getmempoolentry and getrawmempool - Deprecated IS send params for multiple RPCs --- .../dash-core/rpcs/rpcs/getmempoolentry.md | 30 ++++----- .../dash-core/rpcs/rpcs/getrawmempool.md | 61 ++++++++----------- .../devdoc/dash-core/rpcs/rpcs/gobject.md | 2 +- .../devdoc/dash-core/rpcs/rpcs/sendmany.md | 2 +- .../dash-core/rpcs/rpcs/sendrawtransaction.md | 2 +- .../dash-core/rpcs/rpcs/sendtoaddress.md | 2 +- 6 files changed, 40 insertions(+), 59 deletions(-) diff --git a/_includes/devdoc/dash-core/rpcs/rpcs/getmempoolentry.md b/_includes/devdoc/dash-core/rpcs/rpcs/getmempoolentry.md index 62154513..8bab90b5 100644 --- a/_includes/devdoc/dash-core/rpcs/rpcs/getmempoolentry.md +++ b/_includes/devdoc/dash-core/rpcs/rpcs/getmempoolentry.md @@ -110,11 +110,6 @@ The `getmempoolentry` RPC {{summary_getMemPoolEntry}} p: "Optional (0 or more)" d: "The TXIDs of any unconfirmed transactions this transaction depends upon, encoded as hex in RPC byte order" -- n: "→
`instantsend`" - t: "bool" - p: "Required
(exactly 1)" - d: "True if this transaction was sent as an InstantSend one" - - n: "→
`instantlock`" t: "bool" p: "Required
(exactly 1)" @@ -133,23 +128,20 @@ Result: {% highlight json %} { - "size": 226, - "fee": 0.00000226, - "modifiedfee": 0.00000226, - "time": 1519159538, - "height": 79036, - "startingpriority": 0, - "currentpriority": 0, - "descendantcount": 2, - "descendantsize": 452, - "descendantfees": 452, + "size": 372, + "fee": 0.00000375, + "modifiedfee": 0.00000375, + "time": 1566315602, + "height": 159320, + "descendantcount": 1, + "descendantsize": 372, + "descendantfees": 375, "ancestorcount": 1, - "ancestorsize": 226, - "ancestorfees": 226, + "ancestorsize": 372, + "ancestorfees": 375, "depends": [ ], - "instantsend": false, - "instantlock": false + "instantlock": true } {% endhighlight %} diff --git a/_includes/devdoc/dash-core/rpcs/rpcs/getrawmempool.md b/_includes/devdoc/dash-core/rpcs/rpcs/getrawmempool.md index e5224288..ffaf8906 100644 --- a/_includes/devdoc/dash-core/rpcs/rpcs/getrawmempool.md +++ b/_includes/devdoc/dash-core/rpcs/rpcs/getrawmempool.md @@ -128,11 +128,6 @@ The `getrawmempool` RPC {{summary_getRawMemPool}} p: "Optional (0 or more)" d: "The TXIDs of any unconfirmed transactions this transaction depends upon, encoded as hex in RPC byte order" -- n: "→ →
`instantsend`" - t: "bool" - p: "Required
(exactly 1)" - d: "*Added in Dash Core 0.12.3*

Set to `true` for transactions broadcast via the `ix` message (InstantSend lock requested). Set to `false` for standard (non-InstantSend) transactions" - - n: "→ →
`instantlock`" t: "bool" p: "Required
(exactly 1)" @@ -166,44 +161,38 @@ Result: {% highlight json %} { - "8fd1440ed74d3739aa4e1700e9b2fdb32bc5c138fe79dd319f965f67339eb1ce": { - "size": 372, - "fee": 0.00020000, - "modifiedfee": 0.00020000, - "time": 1519928121, - "height": 83907, - "startingpriority": 2224190635.564103, - "currentpriority": 2224190635.564103, - "descendantcount": 2, - "descendantsize": 598, - "descendantfees": 20226, - "ancestorcount": 1, - "ancestorsize": 372, - "ancestorfees": 20000, - "depends": [ - ], - "instantsend": true, - "instantlock": true - }, - "2d914d77305dd968bbd67aeb8604cf7e9d66a7df58bf5216724db69a54000f40": { - "size": 226, + "3bf4985183ddebcb6b1d58fa04dae9728a8f2bf20be298d81e38a8bd2f50ea47": { + "size": 225, "fee": 0.00000226, "modifiedfee": 0.00000226, - "time": 1519928256, - "height": 83907, - "startingpriority": 0, - "currentpriority": 0, + "time": 1566315512, + "height": 159318, "descendantcount": 1, - "descendantsize": 226, + "descendantsize": 225, "descendantfees": 226, "ancestorcount": 2, - "ancestorsize": 598, - "ancestorfees": 20226, + "ancestorsize": 5760, + "ancestorfees": 5780, "depends": [ - "8fd1440ed74d3739aa4e1700e9b2fdb32bc5c138fe79dd319f965f67339eb1ce" + "1b8fdb3ce371c1274ee60df807d631320e7efaf30e7867584eb44b8ec4c19d12" ], - "instantsend": false, - "instantlock": false + "instantlock": true + }, + "1b8fdb3ce371c1274ee60df807d631320e7efaf30e7867584eb44b8ec4c19d12": { + "size": 5535, + "fee": 0.00005554, + "modifiedfee": 0.00005554, + "time": 1566315441, + "height": 159318, + "descendantcount": 2, + "descendantsize": 5760, + "descendantfees": 5780, + "ancestorcount": 1, + "ancestorsize": 5535, + "ancestorfees": 5554, + "depends": [ + ], + "instantlock": true } } {% endhighlight %} diff --git a/_includes/devdoc/dash-core/rpcs/rpcs/gobject.md b/_includes/devdoc/dash-core/rpcs/rpcs/gobject.md index 2dddb774..8428a984 100644 --- a/_includes/devdoc/dash-core/rpcs/rpcs/gobject.md +++ b/_includes/devdoc/dash-core/rpcs/rpcs/gobject.md @@ -121,7 +121,7 @@ The `gobject prepare` RPC prepares a governance object by signing and creating a - n: "`use-IS`" t: "boolean" p: "Optional
(0 or 1)" - d: "*Added in Dash Core 0.13.0*

InstantSend lock the collateral, only requiring one chain confirmation" + d: "*Deprecated and ignored since Dash Core 0.14.1*" {% enditemplate %} diff --git a/_includes/devdoc/dash-core/rpcs/rpcs/sendmany.md b/_includes/devdoc/dash-core/rpcs/rpcs/sendmany.md index 98b78f15..2e9e9c72 100644 --- a/_includes/devdoc/dash-core/rpcs/rpcs/sendmany.md +++ b/_includes/devdoc/dash-core/rpcs/rpcs/sendmany.md @@ -80,7 +80,7 @@ The `sendmany` RPC {{summary_sendMany}} - n: "Use InstantSend" t: "bool" p: "Optional
(0 or 1)" - d: "If set to `true`, send this transaction as InstantSend (default: false)." + d: "*Deprecated and ignored since Dash Core 0.14.1*" {% enditemplate %} diff --git a/_includes/devdoc/dash-core/rpcs/rpcs/sendrawtransaction.md b/_includes/devdoc/dash-core/rpcs/rpcs/sendrawtransaction.md index 64ac2701..3e12e12a 100644 --- a/_includes/devdoc/dash-core/rpcs/rpcs/sendrawtransaction.md +++ b/_includes/devdoc/dash-core/rpcs/rpcs/sendrawtransaction.md @@ -39,7 +39,7 @@ The `sendrawtransaction` RPC {{summary_sendRawTransaction}} - n: "Use InstantSend" t: "bool" p: "Optional
(0 or 1)" - d: "Set to `true` to send as an InstantSend transaction. Set to `false` (the default) to send as a normal transaction" + d: "*Depcrecated and ignored since Dash Core 0.14.1*" {% enditemplate %} diff --git a/_includes/devdoc/dash-core/rpcs/rpcs/sendtoaddress.md b/_includes/devdoc/dash-core/rpcs/rpcs/sendtoaddress.md index 8ec20454..82828a30 100644 --- a/_includes/devdoc/dash-core/rpcs/rpcs/sendtoaddress.md +++ b/_includes/devdoc/dash-core/rpcs/rpcs/sendtoaddress.md @@ -74,7 +74,7 @@ The `sendtoaddress` RPC {{summary_sendToAddress}} - n: "Use InstantSend" t: "bool" p: "Optional
(0 or 1)" - d: "If set to `true`, send this transaction as InstantSend (default: false)." + d: "*Deprecated and ignored since Dash Core 0.14.1*" {% enditemplate %}