[Content] - P2P - Add Spork 6 and update message fields (#57)

* [Content] - P2P - Add spork 6

* [Content] - P2P - Message parameter updates
 - Change dsa/dsi collateral to tx message
 - nLastDsq marked as removed from mnb
 - Add fields to mnp

Closes #34

_includes/devdoc/dash-core/rpcs/rpcs/spork.md

@@ -55,7 +55,8 @@ Result:
 {
   "SPORK_2_INSTANTSEND_ENABLED": 0,
   "SPORK_3_INSTANTSEND_BLOCK_FILTERING": 0,
-  "SPORK_5_INSTANTSEND_MAX_VALUE": 1000,
+  "SPORK_5_INSTANTSEND_MAX_VALUE": 3000,
+  "SPORK_6_NEW_SIGS": 4000000000,
   "SPORK_8_MASTERNODE_PAYMENT_ENFORCEMENT": 0,
   "SPORK_9_SUPERBLOCKS_ENABLED": 0,
   "SPORK_10_MASTERNODE_PAY_UPDATED_NODES": 0,
@@ -93,6 +94,7 @@ Result:
   "SPORK_2_INSTANTSEND_ENABLED": true,
   "SPORK_3_INSTANTSEND_BLOCK_FILTERING": true,
   "SPORK_5_INSTANTSEND_MAX_VALUE": true,
+  "SPORK_6_NEW_SIGS": false,
   "SPORK_8_MASTERNODE_PAYMENT_ENFORCEMENT": true,
   "SPORK_9_SUPERBLOCKS_ENABLED": true,
   "SPORK_10_MASTERNODE_PAY_UPDATED_NODES": true,

_includes/devdoc/ref_p2p_networking.md

@@ -1332,6 +1332,7 @@ Sporks (per [`src/spork.h`][spork.h])
 | 10001 | 2 | `INSTANTSEND_ENABLED` | Turns on and off InstantSend network wide
 | 10002 | 3 | `INSTANTSEND_BLOCK_FILTERING` | Turns on and off InstantSend block filtering
 | 10004 | 5 | `INSTANTSEND_MAX_VALUE` | Controls the max value for an InstantSend transaction (currently 2000 dash)
+| 10005 | 6 | `NEW_SIGS` | Turns on and off new signature format for Dash-specific messages
 | 10007 | 8 | `MASTERNODE_PAYMENT_ENFORCEMENT` | Requires masternodes to be paid by miners when blocks are processed
 | 10008 | 9 | `SUPERBLOCKS_ENABLED` | Superblocks are enabled (10% of the block reward allocated to fund the dash treasury for funding approved proposals)
 | 10009 | 10 | `MASTERNODE_PAY_UPDATED_NODES` | Only current protocol version masternode's will be paid (not older nodes)
@@ -1569,7 +1570,7 @@ queue the remainder of the time.
 | Bytes | Name | Data type | Required | Description |
 | ---------- | ----------- | --------- | -------- | -------- |
 | 4 | nDenom | int | Required | Denomination that will be exclusively used when submitting inputs into the pool
-| 41+ | txCollateral | txIn | Required | Collateral TX that will be charged if this client acts maliciously
+| 216+ | txCollateral | `tx` message | Required | Collateral TX that will be charged if this client acts maliciously
 
 The following annotated hexdump shows a `dsa` message. (The message header has
 been omitted.)
@@ -1756,7 +1757,7 @@ pool, it responds with a `dsf` message.
 | Bytes | Name | Data type | Required | Description |
 | ---------- | ----------- | --------- | -------- | -------- |
 | ? | vecTxDSIn | CTxDSIn[] | Required | Vector of users inputs (CTxDSIn serialization is equal to CTxIn serialization)
-| ? | txCollateral | `tx` message | Required |Collateral transaction which is used to prevent misbehavior and also to charge fees randomly
+| 216+ | txCollateral | `tx` message | Required | Collateral transaction which is used to prevent misbehavior and also to charge fees randomly
 | ? | vecTxDSOut | CTxDSOut[] | Required | Vector of user outputs (CTxDSOut serialization is equal to CTxOut serialization)
 
 The following annotated hexdump shows a `dsi` message. (The message header has
@@ -2254,7 +2255,7 @@ entry and how to validate messages from it.
 | 8 | sigTime | int64_t | Required | Time which the signature was created
 | 4 | nProtocolVersion | int | Required | The protocol version of the masternode
 | # | lastPing | `mnp` message | Required | The last known ping of the masternode
-| 8 | nLastDsq | int64_t | Deprecated | The last time the masternode sent a `dsq` message (for mixing) (DEPRECATED)
+| 8 | nLastDsq | int64_t | Deprecated | **Removed in Dash Core 0.12.3.0**<br><br>The last time the masternode sent a `dsq` message (for mixing) (DEPRECATED)
 
 The following annotated hexdump shows a `mnb` message. (The
 message header has been omitted and the actual IP address has been replaced
@@ -2332,7 +2333,7 @@ integer value requesting a specific number of payment votes. In protocol version
 
 | Bytes | Name | Data type | Required | Description |
 | ---------- | ----------- | --------- | -------- | -------- |
-| 4 | nMnCount | int | Deprecated | Number of masternode payment votes to request<br><br>Deprecated in Dash Core 0.12.3
+| 4 | nMnCount | int | Deprecated | _Deprecated in Dash Core 0.12.3_<br><br>Number of masternode payment votes to request
 
 {% highlight text %}
 Note: Dash Core limits how frequently a masternode payment sync can be
@@ -2363,6 +2364,9 @@ uses a minimum masternode ping time of 10 minutes.
 | 32 | blockHash | uint256 | Required | Block hash from 12 blocks ago (current chaintip minus 12). This offset allows nodes to be slightly out of sync.
 | 8 | sigTime | int64_t | Required | Time which the signature was created
 | 66* | vchSig | char[] | Required | Signature of this message by masternode - verifiable via pubKeyMasternode (66 bytes in most cases. Length (1 byte) + Signature (65 bytes))
+| 1 | fSentinelIsCurrent | bool | Required | True if last sentinel ping was current
+| 4 | nSentinelVersion | uint32_t | Required | The version of Sentinel running on the masternode which is signing the message
+| 4 | nDaemonVersion | uint32_t | Required | The version of dashd on the masternode which is signing the message (i.e. CLIENT_VERSION)
 
 The following annotated hexdump shows a `mnp` message. (The
 message header has been omitted.)