Commit graph

14 commits

Author SHA1 Message Date
David A. Harding
d5900e3df4
Merge branches 'consensus-forking' (pull #615) and 'byte-order' (pull #583) 2014-10-25 14:57:07 -04:00
David A. Harding
1061571b13
Revise Note About Op Codes In Signature Scripts (closes #563)
Based on text and revisions by @petertodd and @luke-jr in pull #563.
2014-10-23 16:03:26 -04:00
David A. Harding
e65d86de21
Mention Bitcoin's RPC Hash Byte Order
* Add a short subsection about the different byte orders used with
  hashes in Bitcoin Core and other software.

* Re-word some text in other sections to mention the byte order
  differences

This commit created based on comments from @SergioDemianLerner (thanks!)
2014-10-23 14:53:52 -04:00
Saivann
5959721141 Fix a typo 2014-10-23 14:48:03 -04:00
David A. Harding
6afc6835bf
Use Terms "Pubkey Script" And "Signature Script"
This modifies commits provided by @petertodd to use the terms "pubkey
script" and "signature script" instead of other terms.

* Rename "scriptPubKey" and "output script" to "pubkey script"
  (suggested by @luke-jr). We leave a token "scriptPubKey" at the point
  where we define pubkey script so that searchers can find it.

* Rename "scriptSig" to "signature script" (suggested by @luke-jr). We
  also leave a token "scriptSig" at this definition point.

* Rename "redeemScript" to "redeem script"

* Defined ECDSA on secp256k1 curve as the crypto used in the Transaction
  section and added references to secp256k1 private/public keys and
  signatures.

* Removed "The Parts Of A Transaction" illustration by commenting it out
  in the HTML. Shoehorning the pubkey/signature script terms into this
  image was becoming difficult, and I'm not very fond of that
  illustration anyway. I'll see if I can think of a nicer replacement
  illustration for some point in the future.

* Add a short paraphrased version @petertodd's description of scripts as
  generalized crypto.

* Updated all the illustrations which referred to either pubkey scripts
  or signature scripts to use these terms.
2014-09-20 15:07:42 -04:00
David A. Harding
89cb2fff08 Small fixes to scriptPubKey/scriptSig pull
* Small grammar fixes.

* Lower case #term-scriptPubKey as all our other anchor links are
  lower case

* Replace script/scripts with scriptPubKey/scriptPubKeys in
  _autocrossref.yaml. (Fixes `make test` errors from broken
  auto-crossref links.)
2014-09-20 08:42:07 -04:00
Peter Todd
c77556c786 Replace misleading 'return' terminology with 'push'
Saying opcodes return values gives the impression the script is being
returned.
2014-09-20 08:37:19 -04:00
Peter Todd
9183f98bc1 Fix incorrect usage of 'script' rather than 'scriptPubKey'
This is causing quite a bit of confusion, for example by people looking
in the Bitcoin Core sourcecode and seeing the term 'scriptPubKey'
instead.
2014-09-20 08:35:39 -04:00
Peter Todd
879f85fca3 Remove OP_1NEGATE mention
Never used in standard transactions
2014-09-18 22:07:10 -04:00
Peter Todd
4010c0228d Fix OP_RETURN misconception
Satoshis sent to an OP_RETURN-using output are simply unspendable; they
do not go to mining fees.
2014-09-18 22:07:10 -04:00
Saivann
ffed3c2529 Create a "Testing Applications" subsection in devel-examples
Move existing "regtest / testnet" texts to the new subsection and link to it
Move Bitcoin Core setup instructions in devel-examples
Add a consistent introduction for devel-(guide/ref/examples)
Fix autocrossref.rb to not add links inside {% highlight %} code blocks
2014-06-12 21:42:42 -04:00
David A. Harding
68cd5b6ff9
Several Corrections & Clarifications Suggested On IRC
**Suggested by @cbeams:**

_includes/ref_block_chain.md:

    * Mention that coinbase is the first transaction in a block.

**Suggested by @gmaxwell:**

_includes/ref_core_rpcs-abcdefg.md:

    * Mention that you need to unlock your wallet when you run out of
      keys in the keypool.

    * Remove erroneous assertion that txindex=1 would allow
      `getreceivedbyaddress` to check balances of addresses not
      belonging to this wallet.

_includes/ref_transactions.md:

    * Clarify that OP_RETURN scripts aren't usually executed because
      they always return false.

en/developer-reference.md

    * Add a warning about using block chain or mempool data in
      executable context.
2014-05-21 23:08:57 -04:00
Saivann
c7eed3e444 Replace P2PH by P2PKH in devel-docs 2014-05-14 00:21:00 -04:00
saivann
46780d3177 Contributions by @saivann to devel docs
Thanks also (in alphabetical order) to @cbeams, @mikehearn, and
@tgeller, among others.

The last pre-squash commit was: c2b8d562aa107c7b68c60946cea14cdccc5159ad
2014-05-09 22:13:59 -04:00